Render hierarchical types as a tree - #1867
Open
PaulHax wants to merge 5 commits into
Open
Conversation
PaulHax
marked this pull request as ready for review
August 21, 2026 20:12
PaulHax
force-pushed
the
hierarchical-type-list
branch
4 times, most recently
from
August 21, 2026 20:47
76947a4 to
e79e363
Compare
PaulHax
force-pushed
the
hierarchical-type-list
branch
from
August 21, 2026 20:48
e79e363 to
fb1a768
Compare
BryonLewis
approved these changes
Aug 26, 2026
BryonLewis
left a comment
Collaborator
There was a problem hiding this comment.
I think this is good as is, below is a list of other things I found while reviewing this PR. They can be broken out into future PR updates:
- Afterwards lets update the behavior on filter-by-frame and the header checkbox toggling on/off all types. It should probably only toggle the current types that are visible on the page. This was an existing issue I just noticed while testing this PR. When filter-by-frame is on it shows only the types for that frame, but the header checkbox toggle will toggle on/off all frames. This is unexpected because if you use the search modifier it only toggles the types that the search displays in the list.
- I think we need to do some CSS modifications or maybe some options to reduce the amount of space taken up in the type list. Currently between the tree structure, the total:frame counts and filter/ other buttons it is getting a little crowded. Below are some options
- reduce the offset for the tree indentation if possible
- The space between the chevron and the checkbox can be reduced a bit
- Make it so Total Count: Frame Count are toggle-able individually in the settings. I.E you can have both on, you can one or the other
- Type Settings update
- Deletion of hierarchy/parent types, I don't think they can be removed right now
- Ability to add your own hierarchy from the interface. We add the lowest level types but it may be nice to edit the types in a hierarchical way at some point and create the hierarchies.
- Option for cascading up types. Somewhere in the settings I think if you turn off a leaf on the tree it should automatically move the type up the branch to the one that is visible. This can be a setting that can be set by the user depending on what they want to see.
Member
Collaborator
|
It isn't, we are using Vuetify 2 and their system, We can save that sort of thing for a future update if we want to write a bunch of custom code to support this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Render hierarchical types as a tree
Bryon called out three follow-ups during review of the original hierarchy PR:
render the Type List as a tree, let a parent toggle its children, and roll child counts into
parents. For datasets without a type hierarchy, the Type List retains its existing flat behavior.
dive-type-hierarchical-list.mp4
Changes
its complete subtree.
suppression rules as the displayed counts.
children that are filtered out.
Manual tests
Test data: upload and extract
hierarchical-type-list.zip
The ZIP opens to
hierarchical-type-list/with self-containedsynthetic/andsefsc/datasets.Type List controls and counts
synthetic/images/, then importsynthetic/annotations.jsonandsynthetic/config.json.Expand Parents / Compact Parents.
fishmaximum-count button.fish; uncheck and recheckjuvenile-red-snapperandred-snapper.Verify: The tree and tri-state checkboxes follow the hierarchy, search keeps the ancestor path, and
the compact breadcrumb is
eukaryota › animalia › chordata. Parent counts include descendants;fishtotals four tracks and seeks to frame 2. Suppressed detections do not reappear in parentcounts or peak navigation.
Real SEFSC-SEAMAP hierarchy
sefsc/, then import its VIAME CSV andconfiguration from the same directory.
Verify: The 24 real tracks render in the correct hierarchy from
eukaryotathrough the eightobserved species.
This is a follow-up to
Define raw and resolved classification boundaries.